Received this feedback today: "Refactored your refactor cause there were some loop holes"(sic)
Ok, buddy. I haven't been told there were holes in my logic since my first semester programming class in college, but let's take a look at what you found. Looked it up and there weren't any holes in the logic, he just wanted the logic moved from the subclass into the base class. Got it, not sure why he didn't just say it that way. It's a reasonable refactor, but my logic was flawless the way it was.
Addendum: Was working on some code at work that's been in production for 3 years (I've been there less than 5 months) that was dropping records from a parsed file. No one noticed, no client complained, I just had to deal with it for an upgrade. Had to trace the logic out and found out that the logic was bad. You want to complain about my logic? Noted.
Trackbacks for Loop holes